Fix duplicated DOM elements not being marked as aria-hidden for better accessibility#8
Open
nascjoao wants to merge 2 commits intocodaworks:masterfrom
Open
Fix duplicated DOM elements not being marked as aria-hidden for better accessibility#8nascjoao wants to merge 2 commits intocodaworks:masterfrom
nascjoao wants to merge 2 commits intocodaworks:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an accessibility issue where duplicated DOM elements were not marked with the
aria-hiddenattribute, causing potential confusion for assistive technologies.It just adds
aria-hidden="true"to the glow effect elements to improve screen reader behavior. So the accessibility tree does not duplicate relevant information.Thank you for considering this fix! Let me know if you'd like me to make any adjustments.